Issue 10601003: Enable cross frame window operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10601003: Enable cross frame window operations (Closed)

Created:
8 years, 6 months ago by vsm

Modified:
8 years, 6 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org, sammccall

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable cross frame window operations This should get everything working for dart2js besides the location and history getters. BUG=3472 TEST=window_open_test Committed: https://code.google.com/p/dart/source/detail?r=8988

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -21 lines)			Patch
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/templates/html/frog/impl_Window.darttemplate	View	1 chunk	+11 lines, -0 lines	1 comment	Download
M	lib/html/frog/html_frog.dart	View	3 chunks	+31 lines, -10 lines	0 comments	Download
M	lib/html/src/frog_DOMImplementation.dart	View	1 chunk	+20 lines, -8 lines	1 comment	Download
M	tests/html/html.status	View	3 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 6 months ago (2012-06-21 16:18:01 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10601003/diff/1/lib/dom/templates/html...
File lib/dom/templates/html/frog/impl_Window.darttemplate (right):

https://chromiumcodereview.appspot.com/10601003/diff/1/lib/dom/templates/html...
lib/dom/templates/html/frog/impl_Window.darttemplate:16: Window _open3(url,
name, options) native "return this.open(url, name, options);";
For consistency, put the main API (open) first and these helpers immediately
following.

https://chromiumcodereview.appspot.com/10601003/diff/1/lib/html/src/frog_DOMI...
File lib/html/src/frog_DOMImplementation.dart (right):

https://chromiumcodereview.appspot.com/10601003/diff/1/lib/html/src/frog_DOMI...
lib/html/src/frog_DOMImplementation.dart:16: bool get length() =>
_length(_window);
Since there is no indexer, there is no point to length.
We should probably have a ChildWindowList or something.

Expand Messages | Collapse Messages