Issue 10600003: Type cast fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10600003: Type cast fix. (Closed)

Created:
8 years, 6 months ago by gram

Modified:
8 years, 6 months ago

Reviewers:
eub, srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Type cast fix. Committed: https://code.google.com/p/dart/source/detail?r=8952

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	lib/unittest/core_matchers.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

8 years, 6 months ago (2012-06-21 00:07:33 UTC) #3

https://chromiumcodereview.appspot.com/10600003/diff/1/lib/unittest/core_matc...
File lib/unittest/core_matchers.dart (right):

https://chromiumcodereview.appspot.com/10600003/diff/1/lib/unittest/core_matc...
lib/unittest/core_matchers.dart:111: if (r != null) reason = r.toString();
Why guard it (r != null)?

(null).toString() should return a valid string.

Expand Messages | Collapse Messages