Issue 10594002: More ICData cleanups: try to use ICData instead of converting it to another intermediate representa…

Issue 10594002: More ICData cleanups: try to use ICData instead of converting it to another intermediate representa… (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Florian Schneider, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More ICData cleanups: try to use ICData instead of converting it to another intermediate representation. This sets the stage for more & simpler optimizations based on collected type feedback. Committed: https://code.google.com/p/dart/source/detail?r=8877

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+267 lines, -302 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2 3	1 chunk	+10 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	3 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+10 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	1 chunk	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	12 chunks	+59 lines, -104 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3	2 chunks	+0 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	11 chunks	+9 lines, -66 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3	2 chunks	+14 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	11 chunks	+44 lines, -31 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	11 chunks	+43 lines, -31 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+8 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	4 chunks	+50 lines, -0 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 2 3	3 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Nice simplification! https://chromiumcodereview.appspot.com/10594002/diff/18001/runtime/vm/flow_graph_compiler_x64.cc File runtime/vm/flow_graph_compiler_x64.cc (right): https://chromiumcodereview.appspot.com/10594002/diff/18001/runtime/vm/flow_graph_compiler_x64.cc#newcode1042 runtime/vm/flow_graph_compiler_x64.cc:1042: if (use_near_jump) { Since Assembler::kNearJump is ...

8 years, 6 months ago (2012-06-19 21:14:18 UTC) #2

srdjan

8 years, 6 months ago (2012-06-19 21:28:17 UTC) #3

Added also a couple of files that I missed the first time.

https://chromiumcodereview.appspot.com/10594002/diff/18001/runtime/vm/flow_gr...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://chromiumcodereview.appspot.com/10594002/diff/18001/runtime/vm/flow_gr...
runtime/vm/flow_graph_compiler_x64.cc:1042: if (use_near_jump) {
On 2012/06/19 21:14:18, regis wrote:
> Since Assembler::kNearJump is bool true, you could simply pass use_near_jump
to
> j().
> Or maybe cleaner, pass num_checks < 5 ? Assembler::kNearJump
> :Assembler::kFarJump.
> Leaving it as is is fine too. 

Leaving it as it is.

Expand Messages | Collapse Messages