Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 10592006: Rework leaf calls as just simple C calls with a signature and not the NativeArgumentDescriptor. (Closed)

Created:
8 years, 6 months ago by siva
Modified:
8 years, 6 months ago
Reviewers:
cshapiro, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Rework leaf calls as just simple C calls with a signature and not the NativeArgumentDescriptor. Committed: https://code.google.com/p/dart/source/detail?r=8881

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -151 lines) Patch
M vm/assembler_ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M vm/assembler_ia32.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M vm/assembler_x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M vm/assembler_x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M vm/code_generator.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M vm/runtime_entry.h View 2 1 chunk +10 lines, -14 lines 0 comments Download
M vm/runtime_entry_ia32.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M vm/runtime_entry_test.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M vm/runtime_entry_x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M vm/stub_code.h View 1 chunk +0 lines, -1 line 0 comments Download
M vm/stub_code_ia32.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M vm/stub_code_ia32_test.cc View 1 2 chunks +7 lines, -13 lines 0 comments Download
M vm/stub_code_x64.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M vm/stub_code_x64_test.cc View 1 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
8 years, 6 months ago (2012-06-19 22:49:00 UTC) #1
Ivan Posva
LGTM -ip
8 years, 6 months ago (2012-06-19 23:12:34 UTC) #2
siva
8 years, 6 months ago (2012-06-19 23:18:16 UTC) #3
cshapiro
8 years, 6 months ago (2012-06-19 23:18:54 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698