Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10591002: Properly parse IDL arrays. (Closed)

Created:
8 years, 6 months ago by Anton Muhin
Modified:
8 years, 6 months ago
Reviewers:
podivilov, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly parse IDL arrays. Arrays, even DOMString[], are not still properly supported in generators (methods with them are mostly ignored), that'll be fixed later. R=podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=8892

Patch Set 1 #

Total comments: 2

Patch Set 2 : Next it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M lib/dom/scripts/idlnode.py View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/dom/scripts/idlparser.py View 1 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anton Muhin
8 years, 6 months ago (2012-06-19 18:04:37 UTC) #1
Anton Muhin
WebKit IDL recently started to use ScriptProfile[] type. I've commented it out in the roll, ...
8 years, 6 months ago (2012-06-19 18:05:48 UTC) #2
sra1
LGTM (fix the regex) https://chromiumcodereview.appspot.com/10591002/diff/1/lib/dom/scripts/idlparser.py File lib/dom/scripts/idlparser.py (right): https://chromiumcodereview.appspot.com/10591002/diff/1/lib/dom/scripts/idlparser.py#newcode287 lib/dom/scripts/idlparser.py:287: return re.compile('\[\]+') I think this ...
8 years, 6 months ago (2012-06-19 20:09:40 UTC) #3
sra1
On 2012/06/19 20:09:40, sra1 wrote: > LGTM (fix the regex) > > https://chromiumcodereview.appspot.com/10591002/diff/1/lib/dom/scripts/idlparser.py > File ...
8 years, 6 months ago (2012-06-19 20:10:13 UTC) #4
Anton Muhin
8 years, 6 months ago (2012-06-20 09:45:04 UTC) #5
Thanks a lot for review, Stephen, submitting.

https://chromiumcodereview.appspot.com/10591002/diff/1/lib/dom/scripts/idlpar...
File lib/dom/scripts/idlparser.py (right):

https://chromiumcodereview.appspot.com/10591002/diff/1/lib/dom/scripts/idlpar...
lib/dom/scripts/idlparser.py:287: return re.compile('\[\]+')
Done, thanks for spotting this, getting rusty w/ regexps.

On 2012/06/19 20:09:40, sra1 wrote:
> I think this recognizes [] []] []]] etc
> Make the regex a raw string like the others.
> 
> r'(\[\])+'

Powered by Google App Engine
This is Rietveld 408576698