Unit tests for the unit test library.

Unit tests for the unit test library.
Committed: https://code.google.com/p/dart/source/detail?r=8994

[eub, 2012-06-21 00:09:42]

LGTM, some proposed cleanup.

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
File tests/lib/unittest/unittest_test.dart (right):

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:36: '${setup}:${teardown}:$uncaughtError';
$uncaughtError unused here?

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:45: callback() {
I'm missing where this is used.

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:103: } else if (testName == 'setup and
teardown test') {
Duplicate 'setup and teardown test'.

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:142: '1:0:0:1:0:::null:single correct
test:',
Comment w/ structure reference.
passed : failed : errors : results : testconfig x : setup : teardown :
uncaughtError[?] : description : message

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:143: '0:1:0:1:0:::null:single failing
test:Expected: <5> but: was <4>',
BTW, might like a helper to construct these strings, w/ some positional args,
some named.

[gram, 2012-06-21 16:48:16]

PTAL

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
File tests/lib/unittest/unittest_test.dart (right):

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:36: '${setup}:${teardown}:$uncaughtError';
On 2012/06/21 00:09:42, eub wrote:
> $uncaughtError unused here?

Currently, as I did not find anything that triggered it, but it may pop up in
future, and is passed to onDone, so I think it is worth capturing.

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:45: callback() {
On 2012/06/21 00:09:42, eub wrote:
> I'm missing where this is used.

I went through many iterations (before isolates and with isolates) trying to get
this stuff to work; there are some artifacts from that. Removed.

https://chromiumcodereview.appspot.com/10584045/diff/1/tests/lib/unittest/uni...
tests/lib/unittest/unittest_test.dart:103: } else if (testName == 'setup and
teardown test') {
On 2012/06/21 00:09:42, eub wrote:
> Duplicate 'setup and teardown test'.

Done.

[eub, 2012-06-21 17:52:20]

https://chromiumcodereview.appspot.com/10584045/diff/5001/tests/lib/unittest/...
File tests/lib/unittest/unittest_test.dart (right):

https://chromiumcodereview.appspot.com/10584045/diff/5001/tests/lib/unittest/...
tests/lib/unittest/unittest_test.dart:16: var tests;
I forgot these - brief comments please?  And I like type annotations on my
globals, though you can make a case these are narrowly scoped.

https://chromiumcodereview.appspot.com/10584045/diff/5001/tests/lib/unittest/...
tests/lib/unittest/unittest_test.dart:55: int x = 0;
First three members could use a comment that they're state to track what tests
have done.  "int x" on a TestConfiguration is a bit o_O.

[eub, 2012-06-21 17:52:36]

lgtm