Issue 10584002: Enable turning on analyzer build in sdk for macs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10584002: Enable turning on analyzer build in sdk for macs. (Closed)

Created:
8 years, 6 months ago by zundel

Modified:
8 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, danrubel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable turning on analyzer build in sdk for macs. Committed: https://code.google.com/p/dart/source/detail?r=8846

Patch Set 2 : Updated another condition stanza in dart.gyp #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	dart.gyp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	tools/create_sdk.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

Flying blind here - I don't have a mac to test this on. The result ...

8 years, 6 months ago (2012-06-18 21:31:31 UTC) #1

ahe

LGTM, it works on my Mac, and so does xcodebuild/ReleaseIA32/dart-sdk/bin/dart_analyzer. https://chromiumcodereview.appspot.com/10584002/diff/2001/dart.gyp File dart.gyp (right): https://chromiumcodereview.appspot.com/10584002/diff/2001/dart.gyp#newcode64 ...

8 years, 6 months ago (2012-06-19 14:01:24 UTC) #2