Add a test for operator[] unparse.

Add a test for operator[] unparse.

Committed: https://code.google.com/p/dart/source/detail?r=8860

[ahe, 2012-06-19 16:42:45]

https://chromiumcodereview.appspot.com/10583016/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/2001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:94: if (node.name is Send &&
node.name.isIndex) sb.add('[]');
Actually, I think this would be slightly cleaner:

Send send = node.name.asSend();
if (send !== null) {
  assert(send is !SendSet);
  visit(send.receiver);
  visit(send.selector);
} else {
  visit(node.name);
}

WDYT?

https://chromiumcodereview.appspot.com/10583016/diff/2001/tests/compiler/dart...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/2001/tests/compiler/dart...
tests/compiler/dart2js/unparser_test.dart:32: MockCompiler compiler = new
MockCompiler();
Could you use this instead:

Node parseMember(String text) =>
  parseBodyCode(text, (parser, tokens) => parser.parseMember(tokens));

[Anton Muhin, 2012-06-19 18:02:05]

https://chromiumcodereview.appspot.com/10583016/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/2001/lib/compiler/implem...
lib/compiler/implementation/tree/unparser.dart:94: if (node.name is Send &&
node.name.isIndex) sb.add('[]');
On 2012/06/19 16:42:45, ahe wrote:
> Actually, I think this would be slightly cleaner:
> 
> Send send = node.name.asSend();
> if (send !== null) {
>   assert(send is !SendSet);
>   visit(send.receiver);
>   visit(send.selector);
> } else {
>   visit(node.name);
> }
> 
> WDYT?

Done.

https://chromiumcodereview.appspot.com/10583016/diff/2001/tests/compiler/dart...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/2001/tests/compiler/dart...
tests/compiler/dart2js/unparser_test.dart:32: MockCompiler compiler = new
MockCompiler();
Neat, thanks, done (almost veni, vidi, vici :)

On 2012/06/19 16:42:45, ahe wrote:
> Could you use this instead:
> 
> Node parseMember(String text) =>
>   parseBodyCode(text, (parser, tokens) => parser.parseMember(tokens));

[ahe, 2012-06-19 18:07:09]

LGTM!

https://chromiumcodereview.appspot.com/10583016/diff/6001/tests/compiler/dart...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/6001/tests/compiler/dart...
tests/compiler/dart2js/unparser_test.dart:8: Node parseMember(String text) =>
Considered moving this to parser_helper.dart?

[Anton Muhin, 2012-06-19 18:09:12]

Thanks a lot for review, submitting.

https://chromiumcodereview.appspot.com/10583016/diff/6001/tests/compiler/dart...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10583016/diff/6001/tests/compiler/dart...
tests/compiler/dart2js/unparser_test.dart:8: Node parseMember(String text) =>
On 2012/06/19 18:07:09, ahe wrote:
> Considered moving this to parser_helper.dart?

Done.