Issue 10582038: Add null check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10582038: Add null check. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
ahe, Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add null check. R=ahe@google.com,smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=8936

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	lib/compiler/implementation/tree/unparser.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/compiler/dart2js/unparser_test.dart	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

lgtm https://chromiumcodereview.appspot.com/10582038/diff/1/lib/compiler/implementation/tree/unparser.dart File lib/compiler/implementation/tree/unparser.dart (right): https://chromiumcodereview.appspot.com/10582038/diff/1/lib/compiler/implementation/tree/unparser.dart#newcode93 lib/compiler/implementation/tree/unparser.dart:93: Send send = node.name !== null ? node.name.asSend() ...

8 years, 6 months ago (2012-06-20 19:25:45 UTC) #2

Anton Muhin

8 years, 6 months ago (2012-06-20 19:34:49 UTC) #3

https://chromiumcodereview.appspot.com/10582038/diff/1/lib/compiler/implement...
File lib/compiler/implementation/tree/unparser.dart (right):

https://chromiumcodereview.appspot.com/10582038/diff/1/lib/compiler/implement...
lib/compiler/implementation/tree/unparser.dart:93: Send send = node.name !==
null ? node.name.asSend() : null;
On 2012/06/20 19:25:45, ahe wrote:
> Perhaps you should change this to use:
> 
> if (node.name is Send) {
>   ...
> }
> 
> Also, indentation seems weird. 

Done.  What's wrong w/ indentation?

Expand Messages | Collapse Messages

Issue 10582038: Add null check. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages