Issue 10579035: - Use NoHandleScope in leaf methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10579035: - Use NoHandleScope in leaf methods (Closed)

Created:
8 years, 6 months ago by siva

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Use NoHandleScope in leaf methods - have a no parameter constructor for NoHandleScope so that we can use that in optimized mode when the Isolate is not available. Committed: https://code.google.com/p/dart/source/detail?r=8955

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	vm/handles.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	vm/handles.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	vm/raw_object.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	vm/runtime_entry.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages