Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 10579015: Update dart2js to use diagnostic kinds. (Closed)

Created:
8 years, 6 months ago by ahe
Modified:
8 years, 6 months ago
Reviewers:
Johnni Winther, kasperl
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Update dart2js to use diagnostic kinds. Committed: https://code.google.com/p/dart/source/detail?r=8843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -61 lines) Patch
M dart/lib/compiler/compiler.dart View 3 chunks +15 lines, -8 lines 0 comments Download
M dart/lib/compiler/implementation/apiimpl.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M dart/lib/compiler/implementation/colors.dart View 1 chunk +4 lines, -14 lines 0 comments Download
M dart/lib/compiler/implementation/compiler.dart View 6 chunks +10 lines, -9 lines 0 comments Download
M dart/lib/compiler/implementation/dart2js.dart View 3 chunks +34 lines, -8 lines 0 comments Download
M dart/lib/compiler/implementation/leg.dart View 2 chunks +1 line, -1 line 0 comments Download
M dart/lib/compiler/implementation/source_file.dart View 2 chunks +6 lines, -14 lines 0 comments Download
M dart/tests/utils/dummy_compiler_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
8 years, 6 months ago (2012-06-19 13:08:40 UTC) #1
kasperl
8 years, 6 months ago (2012-06-19 13:15:37 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698