Issue 10579014: Postpone the argument type optimizations until the types are stable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10579014: Postpone the argument type optimizations until the types are stable. (Closed)

Created:
8 years, 6 months ago by kasperl

Modified:
8 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Postpone the argument type optimizations until the types are stable. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8842

Patch Set 3 : Fix comment. #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -31 lines)			Patch
M	lib/compiler/implementation/ssa/codegen_helpers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/types_propagation.dart	View		8 chunks	+46 lines, -29 lines	2 comments	Download
A	tests/language/propagated_argument_type_check_test.dart	View	1 2	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://chromiumcodereview.appspot.com/10579014/diff/6001/lib/compiler/implementation/ssa/types_propagation.dart File lib/compiler/implementation/ssa/types_propagation.dart (right): https://chromiumcodereview.appspot.com/10579014/diff/6001/lib/compiler/implementation/ssa/types_propagation.dart#newcode50 lib/compiler/implementation/ssa/types_propagation.dart:50: assert(left.isNumber() && !right.isNumber()); // Sanity check. No need ...

8 years, 6 months ago (2012-06-19 13:39:00 UTC) #2

kasperl

8 years, 6 months ago (2012-06-19 13:43:49 UTC) #3

https://chromiumcodereview.appspot.com/10579014/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/ssa/types_propagation.dart (right):

https://chromiumcodereview.appspot.com/10579014/diff/6001/lib/compiler/implem...
lib/compiler/implementation/ssa/types_propagation.dart:50:
assert(left.isNumber() && !right.isNumber());  // Sanity check.
On 2012/06/19 13:39:00, floitsch wrote:
> No need for the comment. Asserts should always be sanity checks.

Updated the comment to give more information.

Expand Messages | Collapse Messages

Issue 10579014: Postpone the argument type optimizations until the types are stable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merge. #

Patch Set 3 : Fix comment. #

Messages