Fix type test elimination using static type propagation in new compiler.

Fix type test elimination using static type propagation in new compiler.
Committed: https://code.google.com/p/dart/source/detail?r=8868

[regis, 2012-06-19 19:12:10]

Srdjan,

I ended up implementing a cleaner solution than what I proposed yesterday. I now
support the 'is more specific than' type relation and use between the static
type and destination type in order to eliminate type tests. See the comment in
the source explaining the reasoning.

Thanks,
Regis

[srdjan, 2012-06-19 20:08:21]

LGTM

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:1749: TypeTestKind test,
MO, it would be more readable if you call this argument test_kind.

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:3206: bool AbstractTypeArguments::TypeTest(TypeTestKind
test,
ditto

[regis, 2012-06-19 20:31:47]

Thanks!

The spec does not define 'is more specific than' for function types and I did
not implement it in this cl (I use a subtype test for functions). However, I
realized that we need to support this test for correctness. I will do it in a
following cl.

-- Regis

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:1749: TypeTestKind test,
On 2012/06/19 20:08:21, srdjan wrote:
> MO, it would be more readable if you call this argument test_kind.

Done.

https://chromiumcodereview.appspot.com/10578018/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:3206: bool AbstractTypeArguments::TypeTest(TypeTestKind
test,
On 2012/06/19 20:08:21, srdjan wrote:
> ditto

Done.