Issue 10576004: Log growth policy decisions when verbose gc is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10576004: Log growth policy decisions when verbose gc is enabled. (Closed)

Created:
8 years, 6 months ago by cshapiro

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Log growth policy decisions when verbose gc is enabled. This change also rationalizes some use of signed and unsigned types and corrects the use of time values recorded for analysis. BUG=3535 Committed: https://code.google.com/p/dart/source/detail?r=9045

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -17 lines)			Patch
	M	runtime/vm/pages.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
	M	runtime/vm/pages.cc	View	1	6 chunks	+35 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.cc#newcode473 runtime/vm/pages.cc:473: history_.GarbageCollectionTimeFraction(), You could save this ...

8 years, 6 months ago (2012-06-22 20:50:37 UTC) #2

cshapiro

8 years, 6 months ago (2012-06-22 21:17:27 UTC) #3

https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.cc#ne...
runtime/vm/pages.cc:473: history_.GarbageCollectionTimeFraction(),
Sounds good.  Done.

As an aside, the names for these state variables, both the local- and
member-variables, could be better.  I will fix that in a forthcoming change.

https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.h
File runtime/vm/pages.h (right):

https://chromiumcodereview.appspot.com/10576004/diff/1/runtime/vm/pages.h#new...
runtime/vm/pages.h:95: int64_t index_;
Switched to an inptr_t.  Done.

Expand Messages | Collapse Messages