Issue 10574003: Fix for issues 1473 and 3521

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10574003: Fix for issues 1473 and 3521 (Closed)

Created:
8 years, 6 months ago by Brian Wilkerson

Modified:
8 years, 6 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issues 1473 and 3521 Committed: https://code.google.com/p/dart/source/detail?r=8821

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -29 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	7 chunks	+43 lines, -23 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java	View	1 chunk	+25 lines, -0 lines	2 comments	Download
M	samples/tests/samples/samples.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm http://codereview.chromium.org/10574003/diff/1/compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java File compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java (right): http://codereview.chromium.org/10574003/diff/1/compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java#newcode46 compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:46: // "}"), Do we need this commented code?

8 years, 6 months ago (2012-06-18 20:51:45 UTC) #2

Brian Wilkerson

8 years, 6 months ago (2012-06-18 20:53:29 UTC) #3

http://codereview.chromium.org/10574003/diff/1/compiler/javatests/com/google/...
File
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java
(right):

http://codereview.chromium.org/10574003/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java:46:
//            "}"),
> Do we need this commented code?

Nope. Just forgot to delete it before uploading. It's deleted now.

Expand Messages | Collapse Messages