Issue 10573027: Use GVN for length loads from arrays and strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10573027: Use GVN for length loads from arrays and strings. (Closed)

Created:
8 years, 6 months ago by Mads Ager (google)

Modified:
8 years, 6 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use GVN for length loads from arrays and strings. - Fix bug in variable allocation. - Treat all HCheck instructions the same when it comes to GVN. They do not have side-effects. R=floitsch@google.com,kasperl@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8900

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
	M	lib/compiler/implementation/ssa/nodes.dart	View		6 chunks	+6 lines, -17 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/variable_allocator.dart	View	1	3 chunks	+18 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10573027/diff/1/lib/compiler/implementation/ssa/variable_allocator.dart File lib/compiler/implementation/ssa/variable_allocator.dart (right): https://chromiumcodereview.appspot.com/10573027/diff/1/lib/compiler/implementation/ssa/variable_allocator.dart#newcode596 lib/compiler/implementation/ssa/variable_allocator.dart:596: // input. Therefore, for Check(checkedInput, otherInput) we would ...

8 years, 6 months ago (2012-06-20 11:29:04 UTC) #2

Mads Ager (google)

8 years, 6 months ago (2012-06-21 07:46:04 UTC) #3

https://chromiumcodereview.appspot.com/10573027/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/variable_allocator.dart (right):

https://chromiumcodereview.appspot.com/10573027/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/variable_allocator.dart:596: // input.
Therefore, for Check(checkedInput, otherInput) we would
On 2012/06/20 11:29:04, kasperl wrote:
> Check -> HCheck?

Done.

Expand Messages | Collapse Messages