Update fauxverride_test to Draft Version 0.10 of the spec.

Update fauxverride_test to Draft Version 0.10 of the spec.

Committed: https://code.google.com/p/dart/source/detail?r=8895

[ahe, 2012-06-20 07:22:15]

This test expands to three "subtests":

language/fauxverride_test/none
language/fauxverride_test/03
language/fauxverride_test/05

language/fauxverride_test/none has no error and no warnings:

m() => 'top level';

class Super {
  static m() => 'super';

  static var i = 'super';

  instanceMethod() => m();

  instanceMethod2() => m();
}

class Sub extends Super {
  static m() => 'sub';

  static var i = 'sub';

  instanceMethod() => m();

  static i() => m();


  foo() => 'foo';
}

language/fauxverride_test/03 has one compile-time error, and no warnings:


m() => 'top level';

class Super {
  static m() => 'super';

  static var i = 'super';

  instanceMethod() => m();

  instanceMethod2() => m();
}

class Sub extends Super {
  static m() => 'sub';

  static var i = 'sub';

  static /// 03: compile-time error
  instanceMethod() => m();

  static i() => m();


  foo() => 'foo';
}

language/fauxverride_test/05 has one compile-time error, and no warnings:

m() => 'top level';

class Super {
  static m() => 'super';

  static var i = 'super';

  instanceMethod() => m();

  instanceMethod2() => m();
}

class Sub extends Super {
  static m() => 'sub';

  static var i = 'sub';

  instanceMethod() => m();

  static i() => m();

  static var instanceMethod2; /// 05: compile-time error

  foo() => 'foo';
}

[kasperl, 2012-06-20 08:58:32]

LGTM.

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
File dart/tests/language/fauxverride_test.dart (right):

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
dart/tests/language/fauxverride_test.dart:71: static i() => m();
So you can have a static method called i and a static variable called i in the
same class? That seems wrong.

[ahe, 2012-06-20 09:04:39]

Thank you, Kasper.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
File dart/tests/language/fauxverride_test.dart (right):

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
dart/tests/language/fauxverride_test.dart:71: static i() => m();
On 2012/06/20 08:58:32, kasperl wrote:
> So you can have a static method called i and a static variable called i in the
> same class?

No. Static members are not inherited.

> That seems wrong.

It is wrong :-)

[zundel, 2012-06-20 09:08:57]

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
File dart/tests/language/fauxverride_test.dart (right):

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
dart/tests/language/fauxverride_test.dart:71: static i() => m();
On 2012/06/20 09:04:40, ahe wrote:
> On 2012/06/20 08:58:32, kasperl wrote:
> > So you can have a static method called i and a static variable called i in
the
> > same class?
> 
> No. Static members are not inherited.
> 
> > That seems wrong.
> 
> It is wrong :-)

Its the lesser of evils maybe.  Unqualified accesses might behave even more
mysteriously than they already do.

[ahe, 2012-06-20 11:00:18]

Thanks for noticing the problem.

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
File dart/tests/language/fauxverride_test.dart (right):

https://chromiumcodereview.appspot.com/10572031/diff/1/dart/tests/language/fa...
dart/tests/language/fauxverride_test.dart:71: static i() => m();
On 2012/06/20 09:08:57, zundel wrote:
> On 2012/06/20 09:04:40, ahe wrote:
> > On 2012/06/20 08:58:32, kasperl wrote:
> > > So you can have a static method called i and a static variable called i in
> the
> > > same class?
> > 
> > No. Static members are not inherited.
> > 
> > > That seems wrong.
> > 
> > It is wrong :-)
> 
> Its the lesser of evils maybe.  Unqualified accesses might behave even more
> mysteriously than they already do.

Actually, after removing the "compile-time error" tags, there are two
declarations of i in the same class (line 62 and line 71). That is not correct.

I have fixed the bug and exposed a bug in dart2js :-(