Issue 10566021: Reapply change to GVN all HFieldGet instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10566021: Reapply change to GVN all HFieldGet instructions. (Closed)

Created:
8 years, 6 months ago by Mads Ager (google)

Modified:
8 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply change to GVN all HFieldGet instructions. - Enable GVN for all HFieldGet. - Mark all non-final HFieldGet as depending on something. - Mark control flow as not having side effects. - Fix dead code elimination to not treat control flow as dead code. - Fix live ranges for HChecks to unconditionally have the same live range as the instruction they are checking. - Added Nicolas' fix for GVN in loops (https://chromiumcodereview.appspot.com/10565025). R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8769

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -30 lines)			Patch
M	lib/compiler/implementation/ssa/nodes.dart	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/ssa/value_set.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/ssa/variable_allocator.dart	View	3 chunks	+4 lines, -3 lines	0 comments	Download
A +	tests/language/gvn_test.dart	View	1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages