Issue 10565036: - Remove passing of obsolete parameter in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10565036: - Remove passing of obsolete parameter in dart2js. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
ahe, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Remove passing of obsolete parameter in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=8812

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	utils/compiler/build_helper.dart	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

lgtm Actually, you could have removed the entire section. But I can also clean that ...

8 years, 6 months ago (2012-06-18 18:24:51 UTC) #3

Ivan Posva

8 years, 6 months ago (2012-06-18 18:28:16 UTC) #4

On 2012/06/18 18:24:51, ahe wrote:
> lgtm
> 
> Actually, you could have removed the entire section. But I can also clean that
> up later.

Fixed with a followup change.

-Ivan

Expand Messages | Collapse Messages