Issue 10563002: Reapply change to GVN all HFieldGet instructions.

Issue 10563002: Reapply change to GVN all HFieldGet instructions. (Closed)

Created:
8 years, 6 months ago by Mads Ager (google)

Modified:
8 years, 6 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply change to GVN all HFieldGet instructions. - Enable GVN for all HFieldGet. - Mark all non-final HFieldGet as depending on something. - Mark control flow as not having side effects. - Fix dead code elimination to not treat control flow as dead code. - Fix live ranges for HChecks to unconditionally have the same live range as the instruction they are checking. R=floitsch@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8717

Patch Set 1 #

Patch Set 2 : Minor style fix. #

Total comments: 6

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -19 lines)			Patch
M	lib/compiler/implementation/ssa/nodes.dart	View	1	4 chunks	+10 lines, -7 lines	4 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/ssa/tracer.dart	View		3 chunks	+8 lines, -5 lines	1 comment	Download
M	lib/compiler/implementation/ssa/variable_allocator.dart	View		3 chunks	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

STV! https://chromiumcodereview.appspot.com/10563002/diff/2001/lib/compiler/implementation/ssa/nodes.dart File lib/compiler/implementation/ssa/nodes.dart (right): https://chromiumcodereview.appspot.com/10563002/diff/2001/lib/compiler/implementation/ssa/nodes.dart#newcode1082 lib/compiler/implementation/ssa/nodes.dart:1082: clearAllSideEffects(); Do you need to do this? I ...

8 years, 6 months ago (2012-06-15 19:45:33 UTC) #3

Mads Ager (google)

8 years, 6 months ago (2012-06-18 07:45:23 UTC) #4

https://chromiumcodereview.appspot.com/10563002/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10563002/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:1082: clearAllSideEffects();
On 2012/06/15 19:45:33, ngeoffray wrote:
> Do you need to do this? I think by default insturctions don't have side
effects.

You are right, we don't need to clear side effects here, we just have to
override the method so nothing is set. Done.

https://chromiumcodereview.appspot.com/10563002/diff/2001/lib/compiler/implem...
lib/compiler/implementation/ssa/nodes.dart:1269: clearAllSideEffects();
On 2012/06/15 19:45:33, ngeoffray wrote:
> ditto

Done.

Expand Messages | Collapse Messages