Issue 10562038: Remove obsolete String + code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10562038: Remove obsolete String + code (Closed)

Created:
8 years, 6 months ago by hausner

Modified:
8 years, 6 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -66 lines)			Patch
M	corelib/src/string.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/lib/string.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	runtime/lib/string.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+2 lines, -24 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

8 years, 6 months ago (2012-06-18 17:55:00 UTC) #3

LGTM, but please make sure that dart2js and the static analyzer still properly
work once you remove the code from the shared interface.

-Ivan