Chek stack overflow in while an do-while node (in order to be able to interrupt loops).

Chek stack overflow in while an do-while node (in order to be able to interrupt loops).
Committed: https://code.google.com/p/dart/source/detail?r=8730

[Vyacheslav Egorov (Google), 2012-06-15 17:43:02]

https://chromiumcodereview.appspot.com/10562010/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10562010/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:1081: }
I am not sure that this is enough for the case like:

while (true) {
  if (true) {
    continue;
  }
}

Easiest way seems to prepend check to the body (insert it as a first
instruction) not append it.

I think similar control flow can affect both DoWhileNode and ForNode.

[srdjan, 2012-06-15 17:56:09]

https://chromiumcodereview.appspot.com/10562010/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10562010/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:1081: }
On 2012/06/15 17:43:02, Vyacheslav Egorov (Google) wrote:
> I am not sure that this is enough for the case like:
> 
> while (true) {
>   if (true) {
>     continue;
>   }
> }
> 
> Easiest way seems to prepend check to the body (insert it as a first
> instruction) not append it.
> 
> I think similar control flow can affect both DoWhileNode and ForNode.

Done.

[Vyacheslav Egorov (Google), 2012-06-15 18:02:51]

lgtm

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1076: if (for_body.is_open()) {
if is not required now. it is always open right after construction.

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1107: if (for_body.is_open()) {
ditto

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1176: if (for_body.is_open()) {
ditto

[srdjan, 2012-06-15 18:05:06]

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1076: if (for_body.is_open()) {
On 2012/06/15 18:02:51, Vyacheslav Egorov (Google) wrote:
> if is not required now. it is always open right after construction.

Done.

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1107: if (for_body.is_open()) {
On 2012/06/15 18:02:51, Vyacheslav Egorov (Google) wrote:
> ditto

Done.

https://chromiumcodereview.appspot.com/10562010/diff/3001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1176: if (for_body.is_open()) {
On 2012/06/15 18:02:51, Vyacheslav Egorov (Google) wrote:
> ditto

Done.