Issue 10560018: Use JavaScriptIndexingBehavior on typed arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10560018: Use JavaScriptIndexingBehavior on typed arrays. (Closed)

Created:
8 years, 6 months ago by sra1

Modified:
8 years, 6 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use JavaScriptIndexingBehavior on typed arrays. Committed: https://code.google.com/p/dart/source/detail?r=8882

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	lib/dom/scripts/systemhtml.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	lib/html/frog/html_frog.dart	View		8 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

Hi Kasper, I can't check this in yet because it reveals a bug: https://code.google.com/p/dart/issues/detail?id=3689 Is ...

8 years, 6 months ago (2012-06-15 22:56:50 UTC) #1

kasperl

LGTM. I think I have a fix for the issue you've been seeing with indexOf: ...

8 years, 6 months ago (2012-06-18 11:42:37 UTC) #2

kasperl

8 years, 6 months ago (2012-06-19 04:53:44 UTC) #3

On 2012/06/18 11:42:37, kasperl wrote:
> LGTM. I think I have a fix for the issue you've been seeing with indexOf:
> 
> https://chromiumcodereview.appspot.com/10553034/

The fix for indexOf/lastIndexOf landed in r8790.

Expand Messages | Collapse Messages