Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 10559064: Migrated cascades tests from dart2js_extra into language tests (Closed)

Created:
8 years, 6 months ago by zundel
Modified:
8 years, 6 months ago
Reviewers:
Kasper Lund, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Migrated cascades tests from dart2js_extra into language tests See issues for VM and Analyzer implementation: http://code.google.com/p/dart/issues/detail?id=2150 http://code.google.com/p/dart/issues/detail?id=3729 Committed: https://code.google.com/p/dart/source/detail?r=8845

Patch Set 1 : # #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -205 lines) Patch
D tests/compiler/dart2js_extra/cascade_precedence_test.dart View 1 chunk +0 lines, -137 lines 0 comments Download
D tests/compiler/dart2js_extra/cascade_test.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download
A + tests/language/cascade_precedence_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/cascade_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language/language.status View 2 chunks +6 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
zundel
I think these two tests are of general utility for all implementations.
8 years, 6 months ago (2012-06-19 11:59:16 UTC) #1
kasperl
LGTM! Thanks, Eric. https://chromiumcodereview.appspot.com/10559064/diff/2001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/10559064/diff/2001/tests/language/language.status#newcode56 tests/language/language.status:56: cascade_test: Pass,Fail # Some cases pass, ...
8 years, 6 months ago (2012-06-19 13:47:15 UTC) #2
zundel
8 years, 6 months ago (2012-06-19 13:54:30 UTC) #3
https://chromiumcodereview.appspot.com/10559064/diff/2001/tests/language/lang...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10559064/diff/2001/tests/language/lang...
tests/language/language.status:56: cascade_test: Pass,Fail  # Some cases pass,
but for the wrong reason
On 2012/06/19 13:47:15, kasperl wrote:
> You could also split them out into the different /01 variants, but I guess
this
> is easier for now -- and still allows you to start making progress.

Enumerating them out isn't any more helpful IMHO.  The feature is unimplemented.
The tests that 'pass' do so because a compile time error is expected but really
its a syntax error on not being able to parse the cascade syntax.

Powered by Google App Engine
This is Rietveld 408576698