Better bitwise and binary arithmetic when the left operand is known to be a number.

Better bitwise and binary arithmetic when the left operand is known to be a primitive.

R=ager@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8836

[kasperl, 2012-06-19 06:20:24]

I'll do something about the HTypeConversion.arg flag -- either make this kind of
type conversion a subclass of HTypeConversion or give this flag a better name.
Maybe I could actually get away with just having three named constructors:

   HTypeConversion()
   HTypeConversion.checked()
   HTypeConversion.argument()

and encode the kind in a int field.

[Mads Ager (google), 2012-06-19 07:15:09]

This will be very nice. I like the idea of the three named constructors for the
type conversions.

https://chromiumcodereview.appspot.com/10558022/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/ssa/types_propagation.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/7001/lib/compiler/implem...
lib/compiler/implementation/ssa/types_propagation.dart:30: bool result = oldType
!= newType;
result -> changed?

[kasperl, 2012-06-19 09:06:48]

I found an interesting issue with the bitwise operation helpers in
js_helpers.dart (they do not check for int inputs). Updated code to match that
and added Florian as a reviewer.

[Mads Ager (google), 2012-06-19 09:10:21]

lgtm

[floitsch, 2012-06-19 11:15:58]

LGTM but one big comment.

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/codegen_helpers.dart:55: // once, so we can
safely visit them an try to merge the input.
and

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/nodes.dart:943: bool isConstantInteger() =>
false;
move next to isConstantNumber

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/nodes.dart:2227:
HTypeConversion.checkedModeCheck(HType type, HInstruction input)
Alternatively we could have 3 subclasses of a HTypeConversion node.
Almost all of our visitors are using the base-visitor which would deal
gracefully with new sub-classes. And the ones that don't probably want to do
something different depending on the class anyways.

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/types_propagation.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/types_propagation.dart:44: if
(!left.isInteger()) convertInput(instruction, left, HType.INTEGER);
we cannot convert an input until the type-propagation is stable.
Failing example:

bar(t) => t;

foo(y) {
  var x = 3;
  for (int i = 0; i < 2; i++) {
    if (i == 1) bar(x + y);
    x = new A();
  }
}

class A {
  A() {}
  operator +(x) => x;
}

main() {
  foo("str");
}

[kasperl, 2012-06-19 11:22:06]

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/codegen_helpers.dart:55: // once, so we can
safely visit them an try to merge the input.
On 2012/06/19 11:15:58, floitsch wrote:
> and

Done.

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/nodes.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/nodes.dart:943: bool isConstantInteger() =>
false;
On 2012/06/19 11:15:58, floitsch wrote:
> move next to isConstantNumber

Done.

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
File lib/compiler/implementation/ssa/types_propagation.dart (right):

https://chromiumcodereview.appspot.com/10558022/diff/12001/lib/compiler/imple...
lib/compiler/implementation/ssa/types_propagation.dart:44: if
(!left.isInteger()) convertInput(instruction, left, HType.INTEGER);
On 2012/06/19 11:15:58, floitsch wrote:
> we cannot convert an input until the type-propagation is stable.
> Failing example:
> 
> bar(t) => t;
> 
> foo(y) {
>   var x = 3;
>   for (int i = 0; i < 2; i++) {
>     if (i == 1) bar(x + y);
>     x = new A();
>   }
> }
> 
> class A {
>   A() {}
>   operator +(x) => x;
> }
> 
> main() {
>   foo("str");
> }

Yeah, that's a good point. I'll fix it and send you the CL.