Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 10558013: For now set the stack buffer size to 16k (we need to compute this during thread start and store it … (Closed)

Created:
8 years, 6 months ago by siva
Modified:
8 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

For now set the stack buffer size to 16k (we need to compute this during thread start and store it in the worker object instead of the current scheme of setting this up in HandleMessage). Adjust stack size to 512KB as all tests seem to run with that limit. Committed: https://code.google.com/p/dart/source/detail?r=8754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/platform/thread_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/thread_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
siva
8 years, 6 months ago (2012-06-15 22:58:35 UTC) #1
srdjan
8 years, 6 months ago (2012-06-15 23:24:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698