Issue 10557005: Add dart:web to dart2js and editor, containing only htmlEscape.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10557005: Add dart:web to dart2js and editor, containing only htmlEscape. (Closed)

Created:
8 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
8 years, 6 months ago

Reviewers:
Emily Fortuna, kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add dart:web to dart2js and editor, containing only htmlEscape. Committed: https://code.google.com/p/dart/source/detail?r=8772

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	lib/compiler/implementation/library_map.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/config/import_any.config	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	lib/web/web.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

I haven't added the library to the VM, only to the editor and dart2js. Someone ...

8 years, 6 months ago (2012-06-15 13:11:22 UTC) #1

kasperl

8 years, 6 months ago (2012-06-18 07:10:24 UTC) #3

LGTM.

https://chromiumcodereview.appspot.com/10557005/diff/1/lib/web/web.dart
File lib/web/web.dart (right):

https://chromiumcodereview.appspot.com/10557005/diff/1/lib/web/web.dart#newcode5
lib/web/web.dart:5: #library("web");
You should make sure to add documentation to these methods (and also the
library) so that it looks nice on api.dartlang.org. You should also update
utils/apidoc/apidoc.dart.

Expand Messages | Collapse Messages