Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10556014: Test for 'if (v as T)' and fix to make 'if as' check useful (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test for 'if (v as T)' and fix to make 'if as' check useful R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +17 lines, -14 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +13 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/completion/CompletionEngineTest.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 6 months ago (2012-06-15 18:37:29 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-15 19:18:04 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698