Issue 10553040: Inline binary And operation for Mint and Smi in new compilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10553040: Inline binary And operation for Mint and Smi in new compilers. (Closed)

Created:
8 years, 6 months ago by regis

Modified:
8 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline binary And operation for Mint and Smi in new compilers. Committed: https://code.google.com/p/dart/source/detail?r=8825

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -23 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	4 chunks	+29 lines, -23 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+51 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	3 chunks	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10553040/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10553040/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode94 runtime/vm/flow_graph_optimizer.cc:94: return ICDataHasReceiverArgumentClasses(ic_data, mint_class, smi_class); Maybe we should modify ...

8 years, 6 months ago (2012-06-18 20:32:36 UTC) #2

regis

8 years, 6 months ago (2012-06-18 21:55:25 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10553040/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10553040/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:94: return
ICDataHasReceiverArgumentClasses(ic_data, mint_class, smi_class);
On 2012/06/18 20:32:36, srdjan wrote:
> Maybe we should modify ICDataHasReceiverArgumentClasses to use class-ids, that
> way you would not need to allocate the class handles above and use kSmi, kMint
> instead?

Done.

Expand Messages | Collapse Messages

Issue 10553040: Inline binary And operation for Mint and Smi in new compilers. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages