Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 10553034: Stop mapping indexOf/lastIndexOf directly to the JavaScript native on indexable primitives. (Closed)

Created:
8 years, 6 months ago by kasperl
Modified:
8 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop mapping indexOf/lastIndexOf directly to the JavaScript native on indexable primitives. Fixes http://dartbug.com/3689. R=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -32 lines) Patch
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 chunk +11 lines, -28 lines 0 comments Download
M tests/corelib/list_test.dart View 3 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 6 months ago (2012-06-18 11:24:19 UTC) #1
ahe
8 years, 6 months ago (2012-06-18 13:07:30 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698