Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 10546174: Better PrettyPrinter output for Return nodes, display tokens and expression. (Closed)

Created:
8 years, 6 months ago by Roman
Modified:
8 years, 6 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Better PrettyPrinter output for Return nodes, display tokens and expression. Committed: https://code.google.com/p/dart/source/detail?r=8774

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Address Anton's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M lib/compiler/implementation/tree/prettyprint.dart View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Roman
You may submit this yourself if I can't do it before vacations.
8 years, 6 months ago (2012-06-14 21:34:26 UTC) #1
Anton Muhin
lgtm w/ comments https://chromiumcodereview.appspot.com/10546174/diff/4002/lib/compiler/implementation/tree/prettyprint.dart File lib/compiler/implementation/tree/prettyprint.dart (right): https://chromiumcodereview.appspot.com/10546174/diff/4002/lib/compiler/implementation/tree/prettyprint.dart#newcode245 lib/compiler/implementation/tree/prettyprint.dart:245: node.beginToken != null ? node.beginToken.stringValue : ...
8 years, 6 months ago (2012-06-15 02:55:56 UTC) #2
Roman
https://chromiumcodereview.appspot.com/10546174/diff/4002/lib/compiler/implementation/tree/prettyprint.dart File lib/compiler/implementation/tree/prettyprint.dart (right): https://chromiumcodereview.appspot.com/10546174/diff/4002/lib/compiler/implementation/tree/prettyprint.dart#newcode245 lib/compiler/implementation/tree/prettyprint.dart:245: node.beginToken != null ? node.beginToken.stringValue : "null"; On 2012/06/15 ...
8 years, 6 months ago (2012-06-17 00:27:03 UTC) #3
Anton Muhin
8 years, 6 months ago (2012-06-18 10:13:47 UTC) #4
I've landed it on your behalf.  Thanks a lot for a neat tool.

Powered by Google App Engine
This is Rietveld 408576698