Issue 10546161: Issue 3516. Make displaying warning for inferred types configurable

Issue 10546161: Issue 3516. Make displaying warning for inferred types configurable (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
messick, Brian Wilkerson

CC:
reviews_dartlang.org, karlklose, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3516. Make displaying warning for inferred types configurable http://code.google.com/p/dart/issues/detail?id=3516 I'm adding also people who expressed opinions about displaying such warnings or not. R=brianwilkerson@google.com,messick@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8684

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -11 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	6 chunks	+17 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	3 chunks	+51 lines, -3 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/plugin.properties	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.tools.ui/plugin.xml	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/preferences/PreferencesMessages.properties	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

messick

LGTM I have a slight preference for putting this on the general page until we ...

8 years, 6 months ago (2012-06-14 05:24:16 UTC) #2

Brian Wilkerson

8 years, 6 months ago (2012-06-14 15:03:20 UTC) #3

LGTM

https://chromiumcodereview.appspot.com/10546161/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10546161/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:1595:
public void test_inferredTypes_noMemberWarnigs() throws Exception {
nit: "Warnigs" --> "Warnings"

https://chromiumcodereview.appspot.com/10546161/diff/1/editor/tools/plugins/c...
File editor/tools/plugins/com.google.dart.tools.ui/plugin.properties (right):

https://chromiumcodereview.appspot.com/10546161/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/plugin.properties:2: # Copyright
(c) 2011, the Dart project authors
nit: copyright year

Expand Messages | Collapse Messages