Issue 10546136: Report error if typedef references itself in type parameter bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546136: Report error if typedef references itself in type parameter bounds (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report error if typedef references itself in type parameter bounds R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8605

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	3 chunks	+8 lines, -2 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10546136/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right): https://chromiumcodereview.appspot.com/10546136/diff/1/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java#newcode2327 compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2327: referencedTypes.add(bound); Do we need a null test in ...

8 years, 6 months ago (2012-06-13 04:31:38 UTC) #2

scheglov

8 years, 6 months ago (2012-06-13 13:38:19 UTC) #3

https://chromiumcodereview.appspot.com/10546136/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10546136/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2327:
referencedTypes.add(bound);
On 2012/06/13 04:31:38, Brian Wilkerson wrote:
> Do we need a null test in case there is no bound, or is it Dynamic when there
is
> no bound?

We have null test later in cycle.

Expand Messages | Collapse Messages