Issue 10545186: Improve equality operation (inline, direct calls).

Issue 10545186: Improve equality operation (inline, direct calls). (Closed)

Created:
8 years, 6 months ago by srdjan

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve equality operation (inline, direct calls). Committed: https://code.google.com/p/dart/source/detail?r=8700

Patch Set 4 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+277 lines, -81 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	1 chunk	+9 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	2 chunks	+22 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	4 chunks	+122 lines, -34 lines	0 comments	Download
	runtime/vm/intermediate_language_x64.cc	View	1 2 3	4 chunks	+123 lines, -34 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermediate_language_ia32.cc#newcode310 runtime/vm/intermediate_language_ia32.cc:310: ASSERT(comp->ClassIdAt(i) != kSmi || i == 0); Add ...

8 years, 6 months ago (2012-06-14 23:59:41 UTC) #2

srdjan

8 years, 6 months ago (2012-06-15 00:27:19 UTC) #3

https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermed...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermed...
runtime/vm/intermediate_language_ia32.cc:310: ASSERT(comp->ClassIdAt(i) != kSmi
|| i == 0);
On 2012/06/14 23:59:41, regis wrote:
> Add parenthesis.

Done.

https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermed...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10545186/diff/8002/runtime/vm/intermed...
runtime/vm/intermediate_language_x64.cc:319: ASSERT(comp->ClassIdAt(i) != kSmi
|| i == 0);
On 2012/06/14 23:59:41, regis wrote:
> ditto

Done.

Expand Messages | Collapse Messages