Give Process.kill an optional argument to specify which signal to send.

Give Process.kill an optional argument to specify which signal to send.


BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=8541

[Anders Johnsen, 2012-06-12 09:04:08]

Added ager+sgjesse as I discussed this change with them.

[Mads Ager (google), 2012-06-12 09:13:44]

lgtm

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process.dart
File runtime/bin/process.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process.da...
runtime/bin/process.dart:185: * On Posix systems, [ProcessSignal]s is used to
send a specific signal
is -> are or remove the 's' after [ProcessSignal]

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process_im...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:231: "Argument 'force' must be a ProcessSignal");
'force' -> 'signal'

[Anders Johnsen, 2012-06-12 09:21:04]

Updated.

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process.dart
File runtime/bin/process.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process.da...
runtime/bin/process.dart:185: * On Posix systems, [ProcessSignal]s is used to
send a specific signal
On 2012/06/12 09:13:44, Mads Ager wrote:
> is -> are or remove the 's' after [ProcessSignal]

Done.

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process_im...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:231: "Argument 'force' must be a ProcessSignal");
On 2012/06/12 09:13:44, Mads Ager wrote:
> 'force' -> 'signal'

Done.

[Bill Hesse, 2012-06-12 10:16:12]

LGTM.

[Søren Gjesse, 2012-06-12 10:22:25]

lgtm

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
File runtime/bin/process.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
runtime/bin/process.dart:96: * signal giving, it'll have different meanings. The
defualt [signal] to
defualt -> default

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
runtime/bin/process_impl.dart:181: _killed = true;
Maybe this should be named _ended now.

[Anders Johnsen, 2012-06-12 12:00:13]

Thanks for the reviews. Committing.

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
File runtime/bin/process.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
runtime/bin/process.dart:96: * signal giving, it'll have different meanings. The
defualt [signal] to
On 2012/06/12 10:22:25, Søren Gjesse wrote:
> defualt -> default

Done.

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10545134/diff/6001/runtime/bin/process...
runtime/bin/process_impl.dart:181: _killed = true;
On 2012/06/12 10:22:25, Søren Gjesse wrote:
> Maybe this should be named _ended now.

Done.