Issue 10544208: Fix indexeddb tests to implement proper setVersion semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544208: Fix indexeddb tests to implement proper setVersion semantics. (Closed)

Created:
8 years, 6 months ago by Anton Muhin

Modified:
8 years, 6 months ago

Reviewers:
podivilov, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix indexeddb tests to implement proper setVersion semantics. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=8805

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -10 lines)			Patch
M	tests/html/html.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View	2 chunks	+5 lines, -2 lines	2 comments	Download
M	tests/html/indexeddb_2_test.dart	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/html/indexeddb_4_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 6 months ago (2012-06-18 16:48:32 UTC) #3

https://chromiumcodereview.appspot.com/10544208/diff/1/tests/html/indexeddb_1...
File tests/html/indexeddb_1_test.dart (right):

https://chromiumcodereview.appspot.com/10544208/diff/1/tests/html/indexeddb_1...
tests/html/indexeddb_1_test.dart:37: step1([e]) {
This is a bit odd...

https://chromiumcodereview.appspot.com/10544208/diff/1/tests/html/indexeddb_1...
tests/html/indexeddb_1_test.dart:56:
transaction.on.complete.add(expectAsync1(step1));
... instead use
(e) => step1()

Expand Messages | Collapse Messages