Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 10544022: Issue 3180. Report shadowing top-level elements by local variable. (Closed)

Created:
8 years, 6 months ago by scheglov
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 3180. Report shadowing top-level elements by local variable. http://code.google.com/p/dart/issues/detail?id=3180 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -6 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +6 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 6 months ago (2012-06-06 05:56:20 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-06 14:02:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698