Mark Expect as deprecated.

Mark Expect as deprecated.
Committed: https://code.google.com/p/dart/source/detail?r=8365

[sethladd, 2012-06-06 22:05:46]

lgtm

[Bob Nystrom, 2012-06-06 22:08:09]

http://codereview.chromium.org/10543035/diff/1/corelib/src/expect.dart
File corelib/src/expect.dart (right):

http://codereview.chromium.org/10543035/diff/1/corelib/src/expect.dart#newcode5
corelib/src/expect.dart:5: /** Expect is deprecated. Use expect() in the unit
test library instead. */
Expect isn't deprecated for use in the language and co19 tests. Those tests
can't rely on the ability to run the unittest library. Clarify that here?

[wittek, 2012-06-14 10:30:35]

FYI

https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
File corelib/src/expect.dart (left):

https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
corelib/src/expect.dart:5: class Expect {
Wondering:
Why is Expect a class, when all methods are static?
Why not top-level functions instead?
If name clashes are the reason, then this should probably be a library instead?

[Bob Nystrom, 2012-06-14 20:02:39]

On 2012/06/14 10:30:35, wittek wrote:
> FYI
> 
>
https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
> File corelib/src/expect.dart (left):
> 
>
https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
> corelib/src/expect.dart:5: class Expect {
> Wondering:
> Why is Expect a class, when all methods are static?
> Why not top-level functions instead?

Expect was created in Dart's primordial past before top-level functions existed.

> If name clashes are the reason, then this should probably be a library
instead?

That's a bit tricky too. What's weird here is that Expect is being used heavily
for the language tests. In order to be able to run those tests on top of an
in-progress not-fully-implemented new Dart implementation, we want them to
require a minimal amount of infrastructure. That's why Expect is in core too:
we've been using it for language tests since before #import() existed.

What we could do is have the language tests use no test infrastructure at all:
have them just throw or print or something to validate. Then we could get rid of
Expect completely.

[wittek, 2012-06-15 07:47:39]

On 2012/06/14 20:02:39, Bob Nystrom wrote:
> On 2012/06/14 10:30:35, wittek wrote:
> > FYI
> > 
> >
>
https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
> > File corelib/src/expect.dart (left):
> > 
> >
>
https://chromiumcodereview.appspot.com/10543035/diff/4001/corelib/src/expect....
> > corelib/src/expect.dart:5: class Expect {
> > Wondering:
> > Why is Expect a class, when all methods are static?
> > Why not top-level functions instead?
> 
> Expect was created in Dart's primordial past before top-level functions
existed.
> 
> > If name clashes are the reason, then this should probably be a library
> instead?
> 
> That's a bit tricky too. What's weird here is that Expect is being used
heavily
> for the language tests. In order to be able to run those tests on top of an
> in-progress not-fully-implemented new Dart implementation, we want them to
> require a minimal amount of infrastructure. That's why Expect is in core too:
> we've been using it for language tests since before #import() existed.
> 
> What we could do is have the language tests use no test infrastructure at all:
> have them just throw or print or something to validate. Then we could get rid
of
> Expect completely.

[wittek, 2012-06-15 07:50:04]

(Ignore the prev message, accidentally hit send...)

Thanks for the explanation, Bob!
I'm purely thinking from a user's perspective here.
And it feels kind of weird (not Darty) to write Expect.equals in unit tests.
I imagine see a thin wrapper around this, although that will lead to some
redundancy, inconsistency and therefore a maintenance burdon :/

[Bob Nystrom, 2012-06-15 16:17:24]

On 2012/06/15 07:50:04, wittek wrote:
> (Ignore the prev message, accidentally hit send...)
> 
> Thanks for the explanation, Bob!
> I'm purely thinking from a user's perspective here.
> And it feels kind of weird (not Darty) to write Expect.equals in unit tests.

You should never need to do that. Use the new API. It's more awesome. The only
people who should be using Expect are people writing Dart language tests.

- bob