Issue 10543023: Fix dart to native dispatch.

Issue 10543023: Fix dart to native dispatch. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 6 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart to native dispatch. R=antonm@google.com,sra@google.com TEST=indexeddb_3_test Committed: https://code.google.com/p/dart/source/detail?r=8341

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+441 lines, -515 lines)			Patch
M	lib/dom/scripts/generator.py	View	7 chunks	+19 lines, -22 lines	2 comments	Download
M	lib/dom/scripts/systemnative.py	View	3 chunks	+22 lines, -14 lines	0 comments	Download
M	lib/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	156 chunks	+392 lines, -478 lines	0 comments	Download
M	tests/html/indexeddb_3_test.dart	View	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov

http://codereview.chromium.org/10543023/diff/1/tests/html/indexeddb_3_test.dart File tests/html/indexeddb_3_test.dart (right): http://codereview.chromium.org/10543023/diff/1/tests/html/indexeddb_3_test.dart#newcode89 tests/html/indexeddb_3_test.dart:89: IDBRequest cursorRequest = objectStore.openCursor(null, 'prev'); Reverted to initial state.

8 years, 6 months ago (2012-06-06 13:26:08 UTC) #2

Anton Muhin

lgtm, neat! http://codereview.chromium.org/10543023/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): http://codereview.chromium.org/10543023/diff/1/lib/dom/scripts/generator.py#newcode395 lib/dom/scripts/generator.py:395: self, rename_type=None, default_value='null'): do you need default ...

8 years, 6 months ago (2012-06-06 14:23:18 UTC) #3

podivilov

8 years, 6 months ago (2012-06-06 15:11:56 UTC) #4

http://codereview.chromium.org/10543023/diff/1/lib/dom/scripts/generator.py
File lib/dom/scripts/generator.py (right):

http://codereview.chromium.org/10543023/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:395: self, rename_type=None, default_value='null'):
On 2012/06/06 14:23:18, antonmuhin wrote:
> do you need default value for default_value?

Yes, it is needed for frog generators.

Expand Messages | Collapse Messages