Fix for http://code.google.com/p/dart/issues/detail?id=3616 - missing dartdoc tooltips for getters …

Fix for http://code.google.com/p/dart/issues/detail?id=3616 - missing dartdoc tooltips for getters and setters; also, poorly formatter tooltips for functions as parameters.
Committed: https://code.google.com/p/dart/source/detail?r=8727

[Brian Wilkerson, 2012-06-15 17:53:19]

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java
(right):

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:231:
String typeName = method.getParameterTypeNames()[i];
nit: We should get the parameter type names and parameter names before the loop
for efficiency.

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:239:
buf.append(" " + paramName);
nit: we're already using append to concatenate so it would be better to not use
"+"

[devoncarew, 2012-06-15 18:01:04]

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java
(right):

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:231:
String typeName = method.getParameterTypeNames()[i];
On 2012/06/15 17:53:19, Brian Wilkerson wrote:
> nit: We should get the parameter type names and parameter names before the
loop
> for efficiency.

Done.

http://codereview.chromium.org/10542177/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/dartdoc/DartDocUtilities.java:239:
buf.append(" " + paramName);
On 2012/06/15 17:53:19, Brian Wilkerson wrote:
> nit: we're already using append to concatenate so it would be better to not
use
> "+"

Done.