Issue 10542117: Allow optional callStack argument to Future.completeException().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542117: Allow optional callStack argument to Future.completeException(). (Closed)

Created:
8 years, 6 months ago by Bob Nystrom

Modified:
8 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow optional callStack argument to Future.completeException(). A corresponding getter returns the value provided. transform() and chain() are both updated to provide this when an exception is thrown from their callbacks. Committed: https://code.google.com/p/dart/source/detail?r=8569

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -26 lines)			Patch
M	corelib/src/future.dart	View	5 chunks	+21 lines, -15 lines	1 comment	Download
M	corelib/src/implementation/future_implementation.dart	View	7 chunks	+22 lines, -9 lines	0 comments	Download
M	tests/corelib/future_test.dart	View	4 chunks	+55 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 6 months ago (2012-06-12 18:38:25 UTC) #2

lgtm!

https://chromiumcodereview.appspot.com/10542117/diff/1/corelib/src/future.dart
File corelib/src/future.dart (right):

https://chromiumcodereview.appspot.com/10542117/diff/1/corelib/src/future.dar...
corelib/src/future.dart:51: Object get callStack();
callStack => stackTrace?

Expand Messages | Collapse Messages