Issue 10542102: Add buffering to _FileInputStream implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542102: Add buffering to _FileInputStream implementation. (Closed)

Created:
8 years, 6 months ago by Bill Hesse

Modified:
8 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add buffering to _FileInputStream implementation. Revert "Revert dart:io file InputStream buffering to fix bugs in it." Recommits r8435, r8401, r8396, r8395, with additional fixes. BUG=3434 TEST= Committed: https://code.google.com/p/dart/source/detail?r=8537

Patch Set 1 #

Patch Set 2 : Fix issue when .close or .readInto are called on a _FileInputStream that is not fully opened. #

Patch Set 3 : Really upload fix for issue. #

Patch Set 4 : Refactor _fillBuffer to not return a future, and to call _checkScheduleCallbacks. #

Patch Set 5 : Rebase to current bleeding-edge #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -92 lines)			Patch
M	runtime/bin/file_impl.dart	View	1 2 3 4	13 chunks	+105 lines, -55 lines	0 comments	Download
M	tests/standalone/io/file_input_stream_test.dart	View	1 2	5 chunks	+30 lines, -7 lines	0 comments	Download
M	tests/standalone/io/file_test.dart	View		2 chunks	+44 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

Everything except the last patch set is what was already committed and reverted. The last ...

8 years, 6 months ago (2012-06-11 14:39:28 UTC) #1

Bill Hesse

Patch set 4 is just a refactoring to allow cancellation of multiple simultaneous calls to ...

8 years, 6 months ago (2012-06-11 15:33:26 UTC) #2

lgtm

Expand Messages | Collapse Messages