Add logging for work items being processed.

Add logging for work items being processed.

That allows to track a set of visited methods with verbose switch on.

R=ahe@google.com,smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=8344

[Roman, 2012-06-06 15:01:25]

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:94:
compiler.log('codegen(${work.element})');
Did you want to use your new method "log" here?
Should that method be private btw?

[Anton Muhin, 2012-06-06 15:03:42]

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:94:
compiler.log('codegen(${work.element})');
Of course I do, thanks a lot for spotting.

It looks like lib private methods are not that popular in this code base, so I'd
rather not.

On 2012/06/06 15:01:25, Roman wrote:
> Did you want to use your new method "log" here?
> Should that method be private btw?

[Roman, 2012-06-06 15:05:30]

lgtm

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10542027/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:94:
compiler.log('codegen(${work.element})');
On 2012/06/06 15:03:42, antonmuhin wrote:
> Of course I do, thanks a lot for spotting.
> 
> It looks like lib private methods are not that popular in this code base, so
I'd
> rather not.
> 
> On 2012/06/06 15:01:25, Roman wrote:
> > Did you want to use your new method "log" here?
> > Should that method be private btw?
> 

Well, that is not good. Comments are also not popular in this code base, that's
not the reason to avoid them :)

[Anton Muhin, 2012-06-06 15:57:45]

Again, thanks a lot for review, Roma.

And again, Peter, I would happily address your concerns.

[ahe, 2012-06-15 13:31:11]

LGTM!