Issue 10542008: Issue 3224. Incorrect return type of negate operator should cause a static warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10542008: Issue 3224. Incorrect return type of negate operator should cause a static warning (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3224. Incorrect return type of negate operator should cause a static warning http://code.google.com/p/dart/issues/detail?id=3224 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8310

Patch Set 2 : Tweak for message #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -6 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View		3 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://chromiumcodereview.appspot.com/10542008/diff/1/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right): https://chromiumcodereview.appspot.com/10542008/diff/1/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java#newcode50 compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:50: OPERATOR_NEGATE_NUM_RETURN_TYPE("operand 'negate' should return numeric type"), "operand" --> ...

8 years, 6 months ago (2012-06-05 19:56:04 UTC) #2

scheglov

8 years, 6 months ago (2012-06-05 23:34:40 UTC) #3

https://chromiumcodereview.appspot.com/10542008/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

https://chromiumcodereview.appspot.com/10542008/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:50:
OPERATOR_NEGATE_NUM_RETURN_TYPE("operand 'negate' should return numeric type"),
On 2012/06/05 19:56:04, Brian Wilkerson wrote:
> "operand" --> "operator"

Done.

Expand Messages | Collapse Messages

Issue 10542008: Issue 3224. Incorrect return type of negate operator should cause a static warning (Closed)

Description

Patch Set 1 #

Patch Set 2 : Tweak for message #

Messages