Generate nested else if

Generate nested else if:

if (a) {
} else if () {
}

instead of:

if (a) {
} else {
  if () {
  }
}
Committed: https://code.google.com/p/dart/source/detail?r=8800

[ngeoffray, 2012-06-14 15:44:14]

FYI: I'm sending this out even though I won't be able to commit it in the next
few days (one day short!, but I can submit it next week). The code works now and
saves some amount of bytes (1k on swarm).

[Lasse Reichstein Nielsen, 2012-06-15 08:31:01]

LGTM

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1354: : IF_STATEMENT;
Maybe (later) consider whether the if-"statement" could be a conditional
expression.

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1576:
generatingInlineStatement = false;
Explain why you set generatingInlineStatement to false
(this might be obvious if the variable was documented).

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:2032: bool
generatingInlineStatement = false;
Move this field to the top of the class, and document what it means and when
it's used.

[kasperl, 2012-06-18 12:04:34]

Lasse, maybe you could land this for Nicolas?

[ngeoffray, 2012-06-18 15:43:25]

Thanks Lasse! Submitting...

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1576:
generatingInlineStatement = false;
On 2012/06/15 08:31:01, Lasse Reichstein Nielsen wrote:
> Explain why you set generatingInlineStatement to false
> (this might be obvious if the variable was documented).

Done.

https://chromiumcodereview.appspot.com/10541173/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:2032: bool
generatingInlineStatement = false;
On 2012/06/15 08:31:01, Lasse Reichstein Nielsen wrote:
> Move this field to the top of the class, and document what it means and when
> it's used.

Done.

[Lasse Reichstein Nielsen, 2012-06-19 09:10:44]

Post-commit-comments :)

https://chromiumcodereview.appspot.com/10541173/diff/5001/dart/lib/compiler/i...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10541173/diff/5001/dart/lib/compiler/i...
dart/lib/compiler/implementation/ssa/codegen.dart:188: * indentation (e.g. an
'if' in an 'else if').
Thanks for the explanation.
Nitpick: "," after "e.g." :)

https://chromiumcodereview.appspot.com/10541173/diff/5001/dart/lib/compiler/i...
dart/lib/compiler/implementation/ssa/codegen.dart:2070: if
(generatingInlineStatement) {
I understand the variable now.
Maybe it could be called "skipNextIndentation" instead. That's pretty clear and
this method would be even more readable.