Issue 10541170: Declare parameters of the bailout version in beginGraph, instead of setting them up in endGraph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10541170: Declare parameters of the bailout version in beginGraph, instead of setting them up in endGraph. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
floitsch, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Declare parameters of the bailout version in beginGraph, instead of setting them up in endGraph. Committed: https://code.google.com/p/dart/source/detail?r=8664

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -19 lines)			Patch
	M	lib/compiler/implementation/ssa/bailout.dart	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	5 chunks	+24 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10541170/diff/4/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10541170/diff/4/lib/compiler/implementation/ssa/codegen.dart#newcode2676 lib/compiler/implementation/ssa/codegen.dart:2676: // Use generic parameters that will be assign ...

8 years, 6 months ago (2012-06-14 15:29:39 UTC) #2

ngeoffray

8 years, 6 months ago (2012-06-14 15:31:47 UTC) #3

Thanks Florian

https://chromiumcodereview.appspot.com/10541170/diff/4/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10541170/diff/4/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:2676: // Use generic parameters
that will be assign to
On 2012/06/14 15:29:39, floitsch wrote:
> assigned

Done.

Expand Messages | Collapse Messages

Issue 10541170: Declare parameters of the bailout version in beginGraph, instead of setting them up in endGraph. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages