Fix for issue 1389

Fix for issue 1389
Committed: https://code.google.com/p/dart/source/detail?r=8465

[zundel, 2012-06-07 22:52:33]

I don't know, this just doesn't seem to be the right solution.  The compiler is
not supposed to get into the state where it throws an ICE - I think that's where
this problem needs to be fixed.  What if it threw an internal compiler error for
some other reason?

one possible alternative solution; create a new kind of exception:
UnterminatedStringException and throw that.  Translate it into an ICE at the top
level of the parser if it isn't caught.

[Brian Wilkerson, 2012-06-08 15:22:08]

> one possible alternative solution; create a new kind of exception:
> UnterminatedStringException and throw that.  Translate it into an ICE at the
top
> level of the parser if it isn't caught.

OK. I made this change. PTAL and let me know what you think of it.

[zundel, 2012-06-08 16:54:48]

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2487: private
static class ParseError extends RuntimeException {
StringInterpolationParseError?  I think this should only happen if a
interpolated string is in the middle of parsing and blows up.

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2545: throw new
InternalCompilerException("Invariant broken");
You didn't originate this terminology, but I feel the description in the
exception is pretty cryptic. Can you think of something better?

[Brian Wilkerson, 2012-06-08 16:58:04]

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2487: private
static class ParseError extends RuntimeException {
Done

http://codereview.chromium.org/10541063/diff/3001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2545: throw new
InternalCompilerException("Invariant broken");
Done

[Brian Wilkerson, 2012-06-08 18:56:35]

So, does this look ok now?

[zundel, 2012-06-08 20:16:03]

lgtm