Issue 10541039: Update pub to new expect API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10541039: Update pub to new expect API. (Closed)

Created:
8 years, 6 months ago by Bob Nystrom

Modified:
8 years, 6 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update pub to new expect API. Committed: https://code.google.com/p/dart/source/detail?r=8367

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -69 lines)			Patch
	M	utils/tests/pub/lock_file_test.dart	View		2 chunks	+11 lines, -11 lines	1 comment	Download
	M	utils/tests/pub/version_test.dart	View		6 chunks	+55 lines, -58 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gram

8 years, 6 months ago (2012-06-06 22:48:29 UTC) #2

LGTM. I did note a couple of equals(0) which could be isZero but that's minor

https://chromiumcodereview.appspot.com/10541039/diff/1/utils/tests/pub/lock_f...
File utils/tests/pub/lock_file_test.dart (left):

https://chromiumcodereview.appspot.com/10541039/diff/1/utils/tests/pub/lock_f...
utils/tests/pub/lock_file_test.dart:36:
expect(lockFile.packages.length).equals(0);
isZero?

Expand Messages | Collapse Messages