Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 10540175: Fix DataView constructor and byte accessors. (Closed)

Created:
8 years, 6 months ago by sra1
Modified:
8 years, 6 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix DataView constructor and byte accessors. Custom constructor is not yet implemented for Dartium. Try again with Dartium and FF tests suppressed. Committed: https://code.google.com/p/dart/source/detail?r=8707

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -35 lines) Patch
M lib/dom/dom.dart View 4 chunks +14 lines, -5 lines 0 comments Download
M lib/dom/frog/dom_frog.dart View 6 chunks +19 lines, -9 lines 0 comments Download
M lib/dom/idl/dart/dart.idl View 1 chunk +28 lines, -0 lines 0 comments Download
M lib/dom/scripts/generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/dom/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
A lib/dom/templates/html/frog/factoryprovider_DataView.darttemplate View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 10 chunks +19 lines, -9 lines 0 comments Download
M lib/html/frog/html_frog.dart View 8 chunks +24 lines, -9 lines 0 comments Download
M tests/html/html.status View 1 3 chunks +3 lines, -0 lines 0 comments Download
A tests/html/typed_arrays_dataview_test.dart View 1 chunk +70 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698