Issue 10540045: - Get handle vtable from a static table for predefined classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540045: - Get handle vtable from a static table for predefined classes. (Closed)

Created:
8 years, 6 months ago by Ivan Posva

Modified:
8 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Google), siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Get handle vtable from a static table for predefined classes. Committed: https://code.google.com/p/dart/source/detail?r=8387

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -5 lines)			Patch
M	runtime/vm/class_table.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	4 chunks	+17 lines, -5 lines	2 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10540045/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://chromiumcodereview.appspot.com/10540045/diff/1/runtime/vm/object.h#newcode4914 runtime/vm/object.h:4914: set_vtable(handle_vtable_); I am wondering if we should pull ...

8 years, 6 months ago (2012-06-07 17:32:25 UTC) #3

Ivan Posva

8 years, 6 months ago (2012-06-07 20:00:56 UTC) #4

https://chromiumcodereview.appspot.com/10540045/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://chromiumcodereview.appspot.com/10540045/diff/1/runtime/vm/object.h#ne...
runtime/vm/object.h:4914: set_vtable(handle_vtable_);
Done. https://chromiumcodereview.appspot.com/10541061

On 2012/06/07 17:32:25, asiva wrote:
> I am wondering if we should pull the "if (raw_ == null_)" case above just
after
> the Smi check and return.
> 
> The rest of the code would indent better without the need for the 'else'.

Expand Messages | Collapse Messages